Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary steps from prepare preview builds script #4461

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 25, 2024

Explanation

These steps handled updating workspace: references, but we don't use those anymore (since #1623).

References

Related to #1623

Changelog

None

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Gudahtt Gudahtt marked this pull request as ready for review June 25, 2024 20:05
@Gudahtt Gudahtt requested a review from a team as a code owner June 25, 2024 20:05
@mcmire
Copy link
Contributor

mcmire commented Jun 25, 2024

It seems that in the original logic we updated all internal dependencies to their equivalents under the @metamask-previews namespace. That no longer happens now, but is it something we want to do? Or... do we already handle that somewhere 🤔

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 27, 2024

In the new workflow, the user of the new preview packages is expected to use resolutions to update any packages that are relevant to what they are testing. The resolutions serve that purpose now instead.

There is a bit of a footgun here still in that you can forget to update the resolutions. But updating them manually in the preview manifests would also be a footgun, as it would force the extension to update each transitive dependency when they otherwise would have been in-range (which could prevent us from noticing that we forgot to release something critical). Either way has risks.

Though regardless, this code being deleted here doesn't do anything today, so we can remove it and consider replacing it with something later if we think it's necessary.

@Gudahtt Gudahtt requested a review from a team June 27, 2024 15:30
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gudahtt Gudahtt force-pushed the remove-unnecessary-prepare-preview-steps branch from e4a28e5 to 99f32bc Compare June 27, 2024 18:12
These steps handled updating `workspace:` references, but we don't use
those anymore (since #1623).
@Gudahtt Gudahtt force-pushed the remove-unnecessary-prepare-preview-steps branch from 99f32bc to 1528246 Compare June 27, 2024 18:15
@Gudahtt Gudahtt merged commit 19b704c into main Jun 27, 2024
116 checks passed
@Gudahtt Gudahtt deleted the remove-unnecessary-prepare-preview-steps branch June 27, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants